commit | 11bc02c2d11fa44afcf7f590c0f678a610ea3404 | [log] [tgz] |
---|---|---|
author | Gabriel Oliveira <gabolvr@google.com> | Wed Apr 12 17:02:02 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 12 17:02:02 2023 |
tree | d06031d316f9e85961040571634ee4ba60627f4c | |
parent | 07896b20392bf7170c6da7d5a92d381bf2880892 [diff] |
Reland "[Profiles] Delete ephemeral profile after removing last keep alive" This is a reland of commit 400a9e4d5abce06a7049355f887cf28d5d603a30 Flaky tests on Mac were caused due to a HistoryMenuBridge keep alive that was not being released. A fix was submited on https://crrev.com/c/4406577. Using ProfileDeletionObserver instead of MultipleProfileDeletionObserver in ProfileManagerBrowserTest.EphemeralProfile test, which waits for OnProfileWasRemoved() instead of OnProfileWillBeRemoved(). Original change's description: > [Profiles] Delete ephemeral profile after removing last keep alive > > This CL refactors the deletion of ephemeral profile by scheduling the > ephemeral profile for deletion when removing its last keep alive. > > The calls to ScheduleEphemeralProfileForDeletion() are removed from > OnBrowserClosed() and when closing the sign-in page and the sync > confirmation page in the profile picker. It is then only called from > RemoveKeepAlive(). > > A kProfileDeletionProcess keep alive is create and is taken before > removing the last keep alive and to keep the profile alive until the > deletion process is completed. It will also be useful for refactoring > the deletion of regular profiles, to avoid them from being randomly > unloaded. > > Bug: 1395367 > Change-Id: Ia4d8b281a36e6ae4caf99abd55b9ccbda8f68075 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345753 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Gabriel Oliveira <gabolvr@google.com> > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1122988} Bug: 1395367 Change-Id: I70a1970401501a2b20f82a11942c7704466911a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4395932 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Gabriel Oliveira <gabolvr@google.com> Cr-Commit-Position: refs/heads/main@{#1129323}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.