Google Git
Sign in
chromium / chromium / src / 11e451f6ed3ca0cfc26528d07b81e1cd67f11098
commit11e451f6ed3ca0cfc26528d07b81e1cd67f11098[log] [tgz]
authorAlex Cooper <alcooper@chromium.org>Tue Jan 04 19:14:16 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 04 19:14:16 2022
treefc37080bb1399ecba53ca28759081d32b28c1738
parent208a1ee1e92ea219be5003addccb5da46474c216 [diff]
[CodeHealth] Remove GetInteger in /chrome/browser/metrics

Removes deprecated usages of Dictionaryvalue::GetInteger and replaces
them with corresponding FindIntKey or FindIntPath usages. Note that
GetInteger would return success but simply not set the value if
provided a nullptr for the out param. For places that simply took a
pointer and passed it through to GetInteger without validating the
pointer this behavior has been preserved.

No behavior changes are intended as a result of this, but some code
patterns needed to be changed as a result of the different return
type.

This CL was uploaded by git cl split.

Bug: 1187034
Change-Id: I5650ec002996080898fddbe6a7cbe4e99cd8fb4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3362444
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/main@{#955268}
1 file changed
tree: fc37080bb1399ecba53ca28759081d32b28c1738
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.