Google Git
Sign in
chromium / chromium / src / 120.0.6099.224
commit3587067cafd6f5b1e567380acb485d96e623ef39[log] [tgz]
authorGreg Thompson <grt@chromium.org>Fri Jan 12 17:07:42 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 12 17:07:42 2024
tree0769a84ba904cfa1ee4174ef7ed38af3821e9d4c
parentcb7184fe0f41858442ceb54a1b1dea2431bce877 [diff]
[Windows] Fix "dr" tracking

r1202869 inadvertently removed the call to OnBrowserLaunch during normal
browser startup. The only remaining use for this function was to create
the browser's DidRunUpdater for normal launches. As a consequence,
post-launch "dr" tracking did not happen until the first rendezvous.

This change fixes "dr" tracking by moving creation of the browser's
DidRunUpdater back into ChromeBrowserMainPartsWin, where it lived until
r479139. This is now possible as a result of removal of the toast in
r1205320.

(cherry picked from commit a8be8325f1ed58c4ec280d1a928e78c500ac7820)

Fixed: 1516887
Change-Id: I5b2852886e4721f7ccc01f9edb3f09d964362958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5177018
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1244787}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185337
Commit-Queue: Srinivas Sista <srinivassista@chromium.org>
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6099@{#1761}
Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
9 files changed
tree: 0769a84ba904cfa1ee4174ef7ed38af3821e9d4c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.