Google Git
Sign in
chromium / chromium / src / 1214b7ce2621761d3cc30e6d9491ecc896e1b618
commit1214b7ce2621761d3cc30e6d9491ecc896e1b618[log] [tgz]
authorJérôme Lebel <jlebel@chromium.org>Fri Feb 23 16:35:20 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 23 16:35:20 2024
tree055968f8f950bad5a7c2c60337a0d6dd0a8f8903
parent14083a07e7c759dcd62267d98e17d4914e2575fd [diff]
[iOS][Waffle] Add default search engine icon

It is possible to have no embedded icons for prepopulated search
engines in EEA countries. This happen when the user select
a prepopulated search engine outside of EEA counties, and then switch
to a EEA countries. The selected search engine is still part of
prepopulated search engine, but it doesn't have an embedded icons.

To avoid DCHECK/CHECK issues, the temporary solution is to use
`default_world_favicon` icon. This patch will be merged in M123.

For M124, the code will be update to download icon if it doesn't exist.

(cherry picked from commit f22d8a2d9fd34e7c7f1d622895230ac4c3afb47e)

Fixed: 326221623, 326553778
Change-Id: Ic38ea3d94bb918a7fd4e2bc02bb934a8ea658bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5314600
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1263888}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318047
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/6312@{#97}
Cr-Branched-From: 6711dcdae48edaf98cbc6964f90fac85b7d9986e-refs/heads/main@{#1262506}
1 file changed
tree: 055968f8f950bad5a7c2c60337a0d6dd0a8f8903
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.