[Autofill] Refactor FormStructure::EncodeUploadRequest().

This CL is a preparation for a followup CL that extends voting
to renderer forms (crrev.com/c/3539862). It refactors some parts
of EncodeUploadRequest() and its helper EncodeFormForUpload():

1. Streamlines the EncodeUploadRequest() API: the out-parameter
  `upload` is now a return value, and deletes the out-parameter
  `encoded_signatures` without substitution.
2. The return value is a vector of AutofillUploadContents rather
   than just a single value. For now, this vector as 0 or 1 elements,
   but the followup CL mentioned above will produce longer vectors.
3. Leaves only the field-specific parts in EncodeFormForUpload() and
   renames it to EncodeFormFieldsForUpload().
4. Introduces a matcher in form_structure_unittest.cc.

Bug: 1007974
Change-Id: Icf2ed82630eda462ea3df6135cdec71405654b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536663
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#984838}
6 files changed
tree: 8d6062b0738c8a92b17b13f1de93126f4a5a68d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.