commit | 76148b464fa482cd3a4fa5bbb3b10f76c73118aa | [log] [tgz] |
---|---|---|
author | Christoph Schwering <schwering@google.com> | Thu Mar 24 15:23:39 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 24 15:23:39 2022 |
tree | 8d6062b0738c8a92b17b13f1de93126f4a5a68d6 | |
parent | b49d8f2b95dc0e3d246c9ed5f0cb188db9e6bc96 [diff] |
[Autofill] Refactor FormStructure::EncodeUploadRequest(). This CL is a preparation for a followup CL that extends voting to renderer forms (crrev.com/c/3539862). It refactors some parts of EncodeUploadRequest() and its helper EncodeFormForUpload(): 1. Streamlines the EncodeUploadRequest() API: the out-parameter `upload` is now a return value, and deletes the out-parameter `encoded_signatures` without substitution. 2. The return value is a vector of AutofillUploadContents rather than just a single value. For now, this vector as 0 or 1 elements, but the followup CL mentioned above will produce longer vectors. 3. Leaves only the field-specific parts in EncodeFormForUpload() and renames it to EncodeFormFieldsForUpload(). 4. Introduces a matcher in form_structure_unittest.cc. Bug: 1007974 Change-Id: Icf2ed82630eda462ea3df6135cdec71405654b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3536663 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#984838}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.