User action when an inline plus address suggestion is accepted (Desktop)
Bug: 355132717
Change-Id: I2cbea8dacda9fd50a8a7629b79f337c3f3b22c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000345
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Norge Vizcay <vizcay@google.com>
Cr-Commit-Position: refs/heads/main@{#1380294}
diff --git a/components/plus_addresses/plus_address_service_impl.cc b/components/plus_addresses/plus_address_service_impl.cc
index aee8ea5..e6d09444 100644
--- a/components/plus_addresses/plus_address_service_impl.cc
+++ b/components/plus_addresses/plus_address_service_impl.cc
@@ -573,9 +573,12 @@
base::RecordAction(base::UserMetricsAction(
"PlusAddresses.FillStandaloneSuggestionAccepted"));
return;
+ case kCreateNewPlusAddressInlineChosen:
+ base::RecordAction(
+ base::UserMetricsAction("PlusAddresses.OfferedPlusAddressAccepted"));
+ return;
case kErrorDuringReserve:
case kCreateNewPlusAddressChosen:
- case kCreateNewPlusAddressInlineChosen:
case kCreateNewPlusAddressInlineReserveLoadingStateShown:
return;
}
diff --git a/components/plus_addresses/plus_address_service_impl_unittest.cc b/components/plus_addresses/plus_address_service_impl_unittest.cc
index 1fb00bb0..09210c6 100644
--- a/components/plus_addresses/plus_address_service_impl_unittest.cc
+++ b/components/plus_addresses/plus_address_service_impl_unittest.cc
@@ -733,6 +733,7 @@
base::test::ScopedFeatureList feature_list{
features::kPlusAddressInlineCreation};
base::HistogramTester histogram_tester;
+ base::UserActionTester user_action_tester;
base::test::TestFuture<std::vector<Suggestion>,
AutofillSuggestionTriggerSource>
update_callback;
@@ -757,6 +758,9 @@
histogram_tester.ExpectUniqueSample(
kPlusAddressSuggestionMetric,
SuggestionEvent::kCreateNewPlusAddressInlineChosen, 1);
+ EXPECT_EQ(user_action_tester.GetActionCount(
+ "PlusAddresses.OfferedPlusAddressAccepted"),
+ 1);
url_loader_factory().SimulateResponseForPendingRequest(
kCreatePlusAddressEndpoint, test::MakeCreationResponse(profile));