commit | 12b88638f0bfdc06d199233c8b51c063b0d4c91b | [log] [tgz] |
---|---|---|
author | msiem <msiem@chromium.org> | Fri Jan 24 18:51:34 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 24 18:51:34 2025 |
tree | 3f92d7f251a1861f354faa5bd42314d35c64fb70 | |
parent | 9d39df1e6478e012e73ddff8dd356401ba312e60 [diff] |
Reland "[PWA]: Cleanup references to Shortcut apps" Added a check to verify the web app scope is valid, otherwise return a nullopt instead of check failing. A future CL will bring back this CHECK() with more testing. This is a reland of commit 0260dcbea8056c8e1b728c6450d45a0762c649dc Original change's description: > [PWA]: Cleanup references to Shortcut apps > > This CL retires the usages of shortcut apps and their behaviors. > As part of the shortcut to diy app migration, apps that were > previously treated like shortcuts should be replaced as DIY apps. > If there is a need for shortcut app like flows, making them > ChromeOS only. > > Removed the uses of empty scopes since DIY apps do not have that > behavior. > > Renamed/refactored `shortcut` methods to `diy` instead. > > Guarding any necessary shortcut app like flows for ChromeOS only. > > More information: go/shortcut-diy-app-migration-cros > > Bug: 339718933, Fixed: 392030215 > Change-Id: I4c6f5585652198e43f38ba07884f75c0b1190f6a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182628 > Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org> > Commit-Queue: May Siem <msiem@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1410594} Bug: 339718933 Change-Id: I08179cb1fbdd1a5c5e63dd446ab505adafa778c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198938 Commit-Queue: May Siem <msiem@chromium.org> Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1411053}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.