commit | 12bd4771e37b6effcf73f35a06bed080a620779a | [log] [tgz] |
---|---|---|
author | Mingyu Lei <leimy@chromium.org> | Thu Oct 12 11:12:34 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 12 11:12:34 2023 |
tree | 208afa31fd303e0273f8a5cf8936caf0c023ff03 | |
parent | a4f5de3ee7f615e3ac41843633d12161287fd4f9 [diff] |
Always reset RFH before `NavigationRequest::OnRequestFailedInternal()` When a NavigationRequest fails, the `render_frame_host_` member in the NavigationRequest might have been chosen previously. If the NavigationRequest is needed for an error page commit, a new value of `render_frame_host_` will be recomputed, which will delete the previously picked speculative RFH. In some cases, the `render_frame_host_` member in the NavigationRequest is not reset before `OnRequestFailedInternal()`, and it will cause the destruction of the NavigationRequest when the RFH is destroyed. Since the NavigationRequest is used for the error page commit, there will be a potential UaF case. This CL ensures the `render_frame_host_` is always set to null before `OnRequestFailedInternal()`, it also removes one of the NavigationRequest reset logic (which we believe should not happen) from the RFH's destructor. A browser test is added for the situation mentioned above. Bug: 1487944 Change-Id: I295dc4fbb95e82bcc494b0b872d4648341aa6177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4924175 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mingyu Lei <leimy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1208754}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.