commit | 134ead415257560bb8b96fad48ca969bbe6a32a0 | [log] [tgz] |
---|---|---|
author | Alex Gough <ajgo@chromium.org> | Thu Nov 14 21:55:05 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 14 21:55:05 2024 |
tree | b3674608197b220a874f183825790258568eba59 | |
parent | 92f01d707d484888579cad539eac5f23a6f5860c [diff] |
Use mojom `|` conditionals for mixed build conditions Mojom now supports `|` and `&` when testing `EnableIf` and `EnableIfNot` conditions in mojom files. Previously, to support multiple conditions, a build.gn file would define a specific `enabled_feature`: ```build.gn if (is_linux || is_win) { enabled_features += [ "is_linux_or_win" ] } ``` This can now be handled directly in the mojom: ```mojom [EnableIf=is_linux|is_win] struct Foo { ... }; ``` This CL applies this build.gn simplification where mixed OS conditionals have been defined, and where no corresponding build flag exists in the .cc/.h source (i.e. the .cc file uses `BUILDFLAG(IS_WIN)||BUILDFLAG(IS_LINUX)`). There should be no functional changes. Bug: 378692747 Change-Id: I2bc404b838f47fe138c0291bb955eed403b11485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6021499 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1383260}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.