| commit | 135ecb54c2f6dac5393b63b51f4f5fc08272f97e | [log] [tgz] |
|---|---|---|
| author | Matthew DeVore <matvore@chromium.org> | Fri May 17 15:33:24 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri May 17 15:33:24 2024 |
| tree | 7d0ecff344c30268e1ead7f05a8d5a944dde80a6 | |
| parent | 9fb22e956d261863f01d79ed74b4543c357f80ee [diff] |
Reland "arc-overview-tracing: allow script invocation" This reverts commit 7ec315c1ab0c5a23121840731f9496aaa1819204. Reason for revert: Resubmitting after Crosier fix and with dbus config in a separate CL. Original change's description: > Revert "arc-overview-tracing: allow script invocation" > > This reverts commit a215ae70e93f5efcaa6aecc4972181df5bcc4998. > > Reason for revert: Causing deterministic failure of ArcIntegrationTest.CreateWindow. See b/340133121. > > Original change's description: > > arc-overview-tracing: allow script invocation > > > > Adds a dbus interface to chrome://arc-overview-tracing functionality so > > that it can be invoked via the command line when no browser windows are > > open. See http://go/scriptify-arc-trace > > > > Bug: b:331467487 > > Test: run 60-second trace and terminate with time-limit > > Test: run trace and terminate by switching focus > > Test: verify messages with GetStatus command > > Test: traces in chrome://arc-overview-tracing > > Test: verify running dbus-send directly as sudo causes rejected message > > Change-Id: I79ef30d83a3ec2627873266a4616d3351bed82d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467026 > > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > > Commit-Queue: Matthew DeVore <matvore@chromium.org> > > Reviewed-by: Yury Khmel <khmel@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1299601} > > Bug: b:331467487, b:340133121 > Change-Id: Ia2cc29137712f681bc90f48df23180188fb63555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528380 > Reviewed-by: Alan Ding <alanding@chromium.org> > Owners-Override: Eriko Kurimoto <elkurin@chromium.org> > Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1299904} Bug: b:331467487, b:340133121 Change-Id: I729486ff79fafab6bc5a2182e14fd1bbccf8ffd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5536270 Commit-Queue: Matthew DeVore <matvore@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alan Ding <alanding@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#1302601}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.