Google Git
Sign in
chromium / chromium / src / 139681b5e982bd3b44835829b208823078eb4b17
commit139681b5e982bd3b44835829b208823078eb4b17[log] [tgz]
authorPaul Adedeji <pauladedeji@google.com>Wed May 04 18:59:27 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 04 18:59:27 2022
treed07b913ce98530199353d7872f1981cca8d7be95
parentfb0da4d0d3c9807d1609005ead8798be963e0d84 [diff]
[ntp] Check if sync is enabled before showing Drive module

Drive is a sync dependent module.

When a user goes to turn on sync in Chrome, their NTP registers that they are synced. When they press cancel everything on the NTP should reflect that. Currently, the Drive module hinges on the initial sync setting and doesn't register changes in sync, till refresh, even if a user cancels sync.

This change only enables the Drive module after a user enables sync via action. The resulting side effect is they now have to refresh their NTP before seeing the Drive module, versus currently where they see it without refreshing.

Video*: http://recall/-/fGxiewmUbUjOWhwT9DjDH1/bO8fG9hgP4vUd0fPZI5FvT

* This video demonstrates the need for refresh only. Fake data can be shown without sync enabled if it is set via chrome://flags.

Change-Id: I2da4a41aefccc09df41812b71de7f8f19eddc875
Bug: 1318421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3617165
Reviewed-by: Mohamad Ahmadi <mahmadi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#999526}
1 file changed
tree: d07b913ce98530199353d7872f1981cca8d7be95
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.