glic: Remove incorrect logic from GlicWindowController::Close. The only way to close the widget is glic_window_widget_.reset(). The call to CloseWithReason() is usually asynchronous and has no effect, but it can be synchronous and that would result in UaF and dangling raw_ptrs. This CL deletes the call to CloseWithReason(). Change-Id: I8d1a818335103c2b27a2f5818798783fa69463c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171226 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/main@{#1405761}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.