commit | 13e7e426deee9e16088ab73bdf01a9b4e2678072 | [log] [tgz] |
---|---|---|
author | Ivan Murashov <ivan.murashov@lge.com> | Tue Nov 19 06:33:13 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 19 06:33:13 2024 |
tree | 529ec4995f9586669e2658aa99d51658a54c3b46 | |
parent | 8a789cfa4476de75287e9ca33377e83c25b5dc6e [diff] |
GCC: Remove check of COLUMN_CASE definition existence in task_manager_columns.cc GCC compilation failed with errors: ../../chrome/browser/ui/task_manager/task_manager_columns.cc:24:34: error: extended character ┐ is not valid in an identifier 24 | #error Surprising name collision ┐(´∇`)┌ | ^ ../../chrome/browser/ui/task_manager/task_manager_columns.cc:24:36: error: extended character ∇ is not valid in an identifier 24 | #error Surprising name collision ┐(´∇`)┌ | ^ ../../chrome/browser/ui/task_manager/task_manager_columns.cc:24:41: error: extended character ┌ is not valid in an identifier 24 | #error Surprising name collision ┐(´∇`)┌ | ^ The errors can be solved by using string literal for message in '#error' directive. But during code review it was decided to remove the check of COLUMN_CASE definition existence as meaningless. Bug: 40565911 Change-Id: Iddcf329027584a4edd792da98195561b80c35734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6028534 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ivan Murashov <ivan.murashov@lge.com> Cr-Commit-Position: refs/heads/main@{#1384784}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.