| commit | b477534e7e10d193e916cd4e2967c589383625b2 | [log] [tgz] |
|---|---|---|
| author | Benjamin Beaudry <bebeaudr@microsoft.com> | Mon Oct 20 22:02:24 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 20 22:02:24 2025 |
| tree | 6e1f9e2cc72743bfb7ee2319e58b0cf39b7e5de2 | |
| parent | afce99a74a38cd43d4e27c371ad8c07c222ae815 [diff] |
[M141] [a11y] Replace fatal 140 CHECK/NOTREACHED by non-fatal alternatives Original change's description: > [a11y] Replace fatal 140 CHECK/NOTREACHED by non-fatal alternatives > > In CL:6062485, we added NOTREACHED(base::NotFatalUntil::M140) and > CHECK(condition, base::NotFatalUntil::M140) in a few places across blink > accessibility. Now that 140 is stable, we observe a spike of crashes > caused by those now-fatal checks. Unfortunately, the person who added > those checks isn't around anymore so the crashes are kinda meaningless > right now. The crashes were meant to raise flags about issues in our > serialization logic and create a sense of priority, but until this > becomes a priority again and we assign someone to that, we should avoid > crashes tabs in release builds. > > Bug: 452392024 > Change-Id: Ie10412a708161a72983b308dfffe5534467b03cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7046819 > Auto-Submit: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Reviewed-by: Lucas Radaelli <lucasradaelli@google.com> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#1531735} (cherry picked from commit ae919b6a000889f66091f44f4636ad073cb17a25) Bug: 453647742,452392024 Change-Id: Ie10412a708161a72983b308dfffe5534467b03cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7063912 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/7390@{#2667} Cr-Branched-From: d481efce5eb300acbb896686676ebd0352a6f1db-refs/heads/main@{#1509326}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.