commit | 14111a62a1b4d87ada04fa0e397a9a9f9f79f065 | [log] [tgz] |
---|---|---|
author | dmangal <dmangal@microsoft.com> | Thu Sep 26 14:43:05 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 26 14:43:05 2024 |
tree | f0553bd83aa865a9771bd888b1df110776b54631 | |
parent | a11fa16b63248b353d3e61a97c491d248fe89368 [diff] |
[views-ax] Migrate kName in ash/wm/desks* This CL migrates the kName attribute in views to be updated whenever its value should change, rather than querying the value and computing it only when needed. The views covered in the CL are: 1) desk_mini_view.cc 2) desk_preview_view.cc 3) desk_textfield.cc Note : On Investigation `CL:4807367` updates the `GetAccessibleNodeData` of this desk_mini_view however, earlier the role for this view was being set by the object desk_preview_. When the file was updated in `CL:4807367` no role was set for this view and as such when we migrate the kname for this class, its expecting a role which is never set anywhere. Thus, there is an explicit need to set the role for this class to migrate kname. Taking inspiration from the code before `CL:4807367` we have propagated the role from desk preview view. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417 Change-Id: I547ad7202a8a592a32f9d84024cdea94b66f5071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854660 Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Daniel Andersson <dandersson@chromium.org> Commit-Queue: Divyansh Mangal <dmangal@microsoft.com> Reviewed-by: Javier Contreras <javiercon@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1360529}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.