Google Git
Sign in
chromium / chromium / src / 14563213c7fda6c6cd5e40de14dd61c5a48ce699
commit14563213c7fda6c6cd5e40de14dd61c5a48ce699[log] [tgz]
authorFlorian Leimgruber <fleimgruber@google.com>Tue Jan 23 13:23:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 23 13:23:54 2024
tree5f803c56ca2f0a73d1c78cad6a3ea0444955bb15
parent2f569d80f9600853d764f92785f07823a4801910 [diff]
Make credit card cleanups independent from sync

The PDMCleaner performs disused card deletion and clears non-settings
origins. Both of these operations only operate on local cards, which are
not synced. There's thus no reason why the code should wait for sync to
be ready. In fact, due to crbug.com/1517515 waiting for sync is
currently broken, so making the logic independent from sync fixes this
issue for cards.

To do so, this CL:
- Renames CleanupData() -> MaybeCleanupAddressData()
- Renames ApplyAddressAndCardFixesAndCleanups() ->
  MaybeCleanupAddressDataAfterSyncChange()
- Renames ApplyDedupingRoutine() -> ApplyAddressDedupingRoutine()
- Renames ApplyCardFixesAndCleanups() -> CleanupCreditCardData(),
  makes it public and calls it after the PDM initialization is complete.
- Removes is_credit_card_cleanup_pending_. This check is no longer
  necessary, since the function is only called from a single place,
  which itself already checks that it's only triggered once.

Bug: 1517515
Change-Id: Id2a07b6b14d3c427c8445f5861346d98c7130d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224728
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1250776}
4 files changed
tree: 5f803c56ca2f0a73d1c78cad6a3ea0444955bb15
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.