commit 14938294162a226a06a7ae9af89792c33ea798eb
author Michael Giuffrida <michaelpg@chromium.org> Fri May 31 21:30:23 2019
committer Commit Bot <commit-bot@chromium.org> Fri May 31 21:30:23 2019
tree 7c22ced9c574da9498c13213259c3a20b5b40c0a
parent 6522ddf21b0738cc3c2a687e685cca56e1f7143c

Modernize handlers in WebUI doc

Message handlers should call AllowJavascript() and shouldn't used
deprecated base::Value methods.

Bug: None
Change-Id: I88ededca440d800bff6ded8bc3f1078c7c83f78f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637647
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665280}

docs/webui_explainer.md

diff --git a/docs/webui_explainer.md b/docs/webui_explainer.md
index ecb4ccf..3b9bd04c 100644
--- a/docs/webui_explainer.md
+++ b/docs/webui_explainer.md
@@ -219,8 +219,11 @@
 }
 
 void OverHandler::HandleBakeDonuts(const base::ListValue* args) {
-  double num_donuts;
-  CHECK(args->GetDouble(0, &num_donuts));  // JavaScript numbers are doubles.
+  AllowJavascript();
+
+  CHECK_EQ(1u, args->GetSize());
+  // JavaScript numbers are doubles.
+  double num_donuts = args->GetList()[0].GetDouble();
   GetOven()->BakeDonuts(static_cast<int>(num_donuts));
 }
 ```
@@ -429,7 +432,7 @@
 
 * renderer doesn't exist yet
 * renderer exists but isn't ready
-* renderer is ready but application-specifici JS isn't ready yet
+* renderer is ready but application-specific JS isn't ready yet
 * tab refresh
 * renderer crash
 
@@ -467,12 +470,11 @@
 
 ```c++
 void OvenHandler::HandleBakeDonuts(const base::ListValue* args) {
-base::Value* callback_id;
-args->Get(0, &callback_id);
-if (!GetOven()->HasGas()) {
-  RejectJavascriptCallback(callback_id,
-                           base::StringValue("need gas to cook the donuts!"));
-}
+  AllowJavascript();
+  if (!GetOven()->HasGas()) {
+    RejectJavascriptCallback(args->GetList()[0],
+                             base::StringValue("need gas to cook the donuts!"));
+  }
 ```
 
 This method is basically just a
@@ -509,10 +511,9 @@
 
 ```c++
 void OvenHandler::HandleBakeDonuts(const base::ListValue* args) {
-  base::Value* callback_id;
-  args->Get(0, &callback_id);
+  AllowJavascript();
   double num_donuts_baked = GetOven()->BakeDonuts();
-  ResolveJavascriptCallback(*callback_id, num_donuts_baked);
+  ResolveJavascriptCallback(args->GetList()[0], num_donuts_baked);
 }
 ```
 
@@ -649,10 +650,11 @@
 
 ```c++
 void DonutHandler::HandleGetNumberOfDonuts(const base::ListValue* args) {
-  base::Value* callback_id;
-  args->Get(0, &callback_id);
+  AllowJavascript();
+
+  const base::Value& callback_id = args->GetList()[0];
   size_t num_donuts = GetOven()->GetNumberOfDonuts();
-  ResolveJavascriptCallback(*callback_id, base::FundamentalValue(num_donuts));
+  ResolveJavascriptCallback(callback_id, base::FundamentalValue(num_donuts));
 }
 ```