Google Git
Sign in
chromium / chromium / src / 14f7e60ca34bccea8d76cbaf8bd6785fa668eecb
commit14f7e60ca34bccea8d76cbaf8bd6785fa668eecb[log] [tgz]
authormlcui <mlcui@google.com>Thu Jul 08 07:13:15 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 08 07:13:15 2021
tree99154924ed8db9b8ff107ed58f897c8dfa7b198f
parentf3f7b8793c08c0bc8ffbf39e36f4e8f6030454fc [diff]
OsSettingsLanguages: Prevent spell check turning on with no languages

Language Settings V2 Update 2 should ensure that users never get into a
situation where spell check is on, but there are no enabled spell check
languages - as that misleadingly shows spell check being on without any
spell check actually occurring. This has already been implemented by
showing the "add spell check languages" dialog when turning on spell
check without any spell check languages.

However, there is a slight edge case with the current implementation.
If the user turns on spell check without any languages, and then closes
or navigates away from the page without adding a language / closing the
"add spell check languages" dialog, the user gets into the
aforementioned misleading state where spell check is on without any
languages.

This CL fixes this by ensuring that spell check is never turned on until
the user adds a spell check language, instead of turning off spell check
when the user _doesn't_ add a language.

Drive-by: Add a TODO for crbug.com/1226913 to fix build deps.

Bug: b:186372498
Change-Id: Ic25d43428f0ec5a23d573395dd328faf21af5b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3008177
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#899449}
3 files changed
tree: 99154924ed8db9b8ff107ed58f897c8dfa7b198f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.