commit 14fb772a3cecb8c3bdfdd3446b56fcb642e3fd64
author Alex Turner <alexmt@chromium.org> Tue Jun 22 17:36:30 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 22 17:36:30 2021
tree c4b39a4846cf83b07a2226a3f4f2cc6c03f7514c
parent c84c650250d5dd37e4a31adfbf1b49a2b6aa6579

Return an AssertionResult when checking FrameAdEvidences in tests

ExpectFrameAdEvidence, which used to call various EXPECT macros to
validate the contents of a FrameAdEvidence object, is renamed to
EvidenceForFrameComprises and now returns an AssertionResult. In case of
a mismatch, the failing result also contains a message explaining the
error.

Previously, when a failure occurred, it was hard to tell which call to
ExpectFrameAdEvidence was at fault as the stack trace only showed the
line number of the failing EXPECT macro in the util file. Now, a failure
will instead trigger an EXPECT macro within the browsertest, aiding
debugging, and the message will indicate the reason for the failure.

Bug: 1220222
Change-Id: Ia5374ba561b2cbe43e384d5ff07084f828682c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965501
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894777}