Google Git
Sign in
chromium / chromium / src / 151464ae2234251edb0bcfeac51acc68e0e432cb
commit151464ae2234251edb0bcfeac51acc68e0e432cb[log] [tgz]
authorKhalid Peer <khalidpeer@chromium.org>Mon Apr 14 14:45:48 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 14 14:45:48 2025
treef8021350723e0192996e688d27dd98bf9116c848
parent7b6c3680eff9ae15273f68e6b158d26f2adbadc5 [diff]
[M136] [omnibox] Add joint slicing for `Omnibox.SuggestionShown` metric.

Original change's description:
> [omnibox] Add joint slicing for `Omnibox.SuggestionShown` metric.
> 
> In order to support deeper analysis of the `Omnibox.SuggestionShown`
> metric, this CL adds the ability to slice by both
> ClientSummarizedResultType and page context.
> 
> This enables us to answer questions like: Did the user see at least one
> Search/URL suggestion, during the course of the Omnibox session, when
> they selected a suggestion in the given page context?
> 
> In the long-term, we'll likely be moving these key Omnibox metrics
> server-side, but for now we're implementing these client-side in the
> interest of supporting Stable experimentation ASAP.
> 
> Bug: 402519775
> Change-Id: I829cc675ae86da6f5a0e1c71a0eb777613cf3195
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6439233
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1444926}

Bug: 409787568,402519775
Change-Id: I829cc675ae86da6f5a0e1c71a0eb777613cf3195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6449574
Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7103@{#849}
Cr-Branched-From: e09430c64983fc906f37a9f7e6806275c9b67b86-refs/heads/main@{#1440670}
3 files changed
tree: f8021350723e0192996e688d27dd98bf9116c848
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.