Google Git
Sign in
chromium / chromium / src / 157ea94621524e3785b812bc0c0c8ebfd6d8873f
commit157ea94621524e3785b812bc0c0c8ebfd6d8873f[log] [tgz]
authorAaron Massey <aaronmassey@google.com>Wed Jun 04 17:39:25 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 04 17:39:25 2025
treeb79dda3f72d0ec19e6c5d5b3a507b245816b6225
parent93cc2a508ec46d6d5d7e7735284996420a25e809 [diff]
printing: Guard more new margin/scale code behind MarginsAndScale flag

Recent changes to the ChromeOS custom margin and scaling logic
resulted in instability for non-borderless zero margin prints.

Guard the new custom margin/scale logic behind the associated feature
flag for safer prototyping.

(cherry picked from commit f0de8dabd297b9c04e64c3b89d88e256eb94193e)

Fixed: 422149165
Bug: 417095701, 418878610, 422017464
Test: Print with zero margins on US letter
Test: Print duplex with zero margins on US letter
Change-Id: Ieecdbde8c1ef8efcfa3325757f0fe0a52158dda0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6579764
Reviewed-by: Nathan Muggli <nmuggli@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Aaron Massey <aaronmassey@google.com>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Cr-Original-Commit-Position: refs/heads/main@{#1467083}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6617342
Commit-Queue: Aaron Massey <aaronmassey@google.com>
Cr-Commit-Position: refs/branch-heads/7204@{#546}
Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
4 files changed
tree: b79dda3f72d0ec19e6c5d5b3a507b245816b6225
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.