Google Git
Sign in
chromium / chromium / src / 15ce3aa27e535b9816f04d0ab226fd202d1319d7
commit15ce3aa27e535b9816f04d0ab226fd202d1319d7[log] [tgz]
authorRune Lillesveen <futhark@chromium.org>Mon May 26 09:11:10 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 26 09:11:10 2025
treefef8176489e91a20822809a20837e8902c47c1f4
parent9b1b4b65a46f01243313e2f2f73aa8472b0232b5 [diff]
Reland container queries invalidation with MSAN fix

First change:
-------------

Invalidate container queries on sibling changes

Rely on marking container elements for style recalc on nth-invalidations
if the evaluator has been invoked with a tree counting function.

If a container evaluator depends on tree counting function evaluation,
and we recalc style for it for whatever reason, we recompute the
CSSContainerValues. To avoid that we would have needed a different way
of invalidating the container than relying on style recalc.

Pull the sibling-index() dependency out of ComputeValue() to know when
we need to invalidate the container values for style() queries. There is
a pre-existing bug for style() queries for other units like rem units.
That will be fixed in a follow-up CL.

Second change:
--------------

Emit unit flags from style() query evaluations

Fixes unit invalidation for registered custom property container
queries.

Bug: 40282719, 419454587, 419862635
Change-Id: I67d1214679f6ba2ef88da294fd57e03d99de5919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6584554
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Auto-Submit: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Daniil Sakhapov <sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1465396}
10 files changed
tree: fef8176489e91a20822809a20837e8902c47c1f4
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.