DevTools: Ensure to fetch contrast for the right element in highlight. In NodeHighlightTool ctor, we may override which node is actually used, if the node in question is under a content-visibility element which prevents visibility. When later on we fetch the contrast values for that node, we should use |node_| as opposed to |node| since at that time, the two values could be different. Note that this changes includes leveraging NodeHighlightTool directly in the getHighlightObjectForTest function, since previously the two implementations were different. The updated test would now fail without the |node| -> |node_| switch, but passes with the switch. R=chrishtr@chromium.org Fixed: 1090371 Change-Id: Ic98aafaf02818203311bf6a745575a0612612914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228124 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775172}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.