Google Git
Sign in
chromium / chromium / src / 165d26c4fd64d1dbac9426b8f33f802a9bcdd2f5
commit165d26c4fd64d1dbac9426b8f33f802a9bcdd2f5[log] [tgz]
authorFlorian Leimgruber <fleimgruber@google.com>Wed Apr 24 14:31:25 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 24 14:31:25 2024
tree0456349a88d7d4fe98325eba3268374cff9d4b0c
parent46e6f2d5c23bc41a6fbb89be8e8798e0950cb6cd [diff]
Remove PersonalDataManager::Init()

PersonalDataManager (PDM) is a keyed service. It's construction is
currently split into two steps - the constructor and an Init() function.
The constructor only takes the app locale and a country code, while
Init() is used to inject all services that the PDM depends on. Init()
returns void an cannot fail.

The PDMFactory calls Init() immediately after the constructor, so there
is little reason to have that function. It only seems to make the code
more complicated, as state needs to be kept between the constructor and
Init(), which could otherwise just be forwarded.

This CL merges Init() with the constructor, by adding all the parameters
there.

For most tests, a TestPDM is used, which never calls Init() (since all
dependent services are faked somehow). As such, the TestPDM's PDM
constructor call is updated with a bunch of nullptrs.

Bug: b/322170538
Change-Id: Id46bc82e399d3318177e9609fed9f4f977bcec04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476491
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1291864}
10 files changed
tree: 0456349a88d7d4fe98325eba3268374cff9d4b0c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.