commit 16740473879b4c0c61e5f0be4b9016c9cc482762
author David Benjamin <davidben@chromium.org> Thu Oct 20 22:28:12 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Oct 20 22:28:12 2022
tree 34fc4fa4712f4d1c30cf424c4deaedf91f15ca49
parent 6253bd9994e510c752a147443fa779457618791d

Make SerializedScriptValue::Create take a span<const uint8_t>

This fixes a few issues:

First, every caller of the bytes-based
SerializedScriptValue::Create(const char *, size_t) overload actually
had a span of uint8_t and needed to cast. We should just fix the type.
Along the way, migrate it to base::span which is more convenient in most
cases.

Doing so ran into the String(const LChar*) constructor; by being
implicit, that constructor actually fires on uint8_t[N] because arrays
decay to pointers and LChar is the same type as uint8_t. This means
every String|span<uint8_t> overload set is ambiguous on byte arrays. To
mitigate this, I've made that constructor explicit. Ideally it'd be
called String::FromLatin1 or something, but I've left that alone here.

Finally, this fixes the SerializedValue() test helper function to no
longer require even-length input. This, as I understand, is a remnant of
when the serializer worked on Blink strings. But now this helper is
exactly the same as SerializedScriptValue::Create except it is slightly
shorter and works with initializer lists. I've stopped short of
completely removing it because the overload set makes an initializer
list not quite work right. (The language doesn't know the type of the
values in the initializer list.)

(The original motivation of this change was
https://chromium-review.googlesource.com/c/chromium/src/+/3930754 ran
into issues with SerializedValue's DCHECK. Tugging on that revealed a
chain of issues, so I've tried to chisel through a few of them.)

Bug: none
Change-Id: Icf571cfe3ec4dce7eaf29b28fb7021e615290129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960433
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061850}