commit | 1682b665a0a1b666937387c4f876332e268667f0 | [log] [tgz] |
---|---|---|
author | Mason Freed <masonf@chromium.org> | Tue Jan 07 18:37:14 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 07 18:37:14 2025 |
tree | c502cd1d311477fcaa5128ac0916a445cc4e612f | |
parent | 62848a183217103740ad007fbe84da375bd03f59 [diff] |
[Reland, x2] Handle appearance value changes during <select> showPicker. *** GARDENERS: *** Please don't revert this CL again. Simply mark the switch-picker-appearance.tentative.html test as failing in TestExpectations and that should fix the problem. Thanks! ****************** When the appearance value changes as the result of the picker opening (e.g. via `::picker(select):open {appearance:auto}` or similar), we close the picker to avoid any oscillation or nonsensical behavior. This CL implements this change. The original CL [1] was reverted due to a strange bot failure [2] where the new set of promise_tests somehow fail because blink_wpt_tests is expecting an expectation file with a single blank line. I added a "Failure" expectation to hopefully avoid that, in Patchset 3. The first reland CL [3] was reverted due to a (fairly serious, in my opinion) bug [4] in the WPT importer that was missed by the gardener (it was nuanced) and resulted in this CL getting reverted again. This re-land includes `Timeout` as a failure mode for all platforms. [1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831 [2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview [3] https://chromium-review.googlesource.com/c/chromium/src/+/6107689 [4] https://issues.chromium.org/issues/367426156#comment13 Fixed: 376097114,370536090,367426156 Bug: 384394713 Change-Id: I2d22aa452b071ac9eb259dd4ae4e097b970b8851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150897 Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1403101}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.