commit | 169a28c073195f8a778f28048eaad80b7235e081 | [log] [tgz] |
---|---|---|
author | sangwoo.ko <sangwoo.ko@navercorp.com> | Sun Jun 16 00:49:19 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Jun 16 00:49:19 2019 |
tree | 3e69956b50fe91f8f7be5433637f2dc6aafeaf03 | |
parent | 615d0eca8563a114f48694c2eefb189d51a02862 [diff] |
Reland "Use views::AnimationDelegateViews wherever possible" This is a reland of 9f25eee5655d88a36f9a20d14331d2fdec9a4ca0 What caused crash was that AnimationDelegateViews was accessing AnimationContainer via raw pointer already freed. It was assumed that AnimationDelegateViews outlives AnimationContainer but it doesn't. We should use scoped_refptr to retain ownership. Original change's description: > Use views::AnimationDelegateViews wherever possible > > Replace gfx::AnimationDelegate with views::AnimationDelegateViews. > This will help gfx::AnimationContainer be driven by ui::Compositor. > > TODO: > * files under ash/ > * other files which can't use AnimationDelegateViews. > > Bug: 953585 > Change-Id: I39279bcc779c72bedb26f8c1e43661f0a0a9691d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616921 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662481} Bug: 953585 Change-Id: Id1111845813309a92c571a3bd81e92081e95e115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626839 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#669524}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .