Google Git
Sign in
chromium / chromium / src / 1709355a2045a4498c65166b5687c75623146b0d
commit1709355a2045a4498c65166b5687c75623146b0d[log] [tgz]
authorMenard, Alexis <alexis.menard@intel.com>Wed Apr 03 14:00:41 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 03 14:00:41 2024
tree3a32ba5dee8f7eaaf2422736293a40e0aca9f6c5
parentb432bcaec601e4713f22da5d742c714ca7b7526a [diff]
[Viewport Segments] Make sure to bail out from native backends callbacks
if we're overriding the display feature for testing.

When overriding the display feature for testing we may still receive
display configuration changes from the platform/OS so we need to bail
out early.

This bug was shown when running RenderWidgetHostFoldableCSSTest.FoldablesCSSWithReload
with RenderDocument enabled. When RenderDocument is enabled, a new RWHVA is
recreated at reload so the native posture platform observers are installed again
on the new instance and override the display feature set when testing
making the test to fail. It did not happen on the Aura backend because
the tests never ran on a foldable device (where the Windows backend would
send something) but it could have failed as well, so the patch is also
addressing the Aura counterpart.

Bug: 330118238
Change-Id: I7915ed708f3224f7d2df6744174add009d95e448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415653
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Alexis Menard <alexis.menard@intel.com>
Cr-Commit-Position: refs/heads/main@{#1281802}
2 files changed
tree: 3a32ba5dee8f7eaaf2422736293a40e0aca9f6c5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.