Google Git
Sign in
chromium / chromium / src / 175d9f804d55c711954fb1b4532b09f0699a32a7
commit175d9f804d55c711954fb1b4532b09f0699a32a7[log] [tgz]
authorMin Qin <qinmin@chromium.org>Wed Oct 06 20:05:16 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 06 20:05:16 2021
tree4e392498319deb24f119d2c82b546f51f2533804
parent27fabc9229425100467f8f4db55439f111f3a8e5 [diff]
limit download to only one per tab

This CL will limit number of download to one on a tab. Previously
more than 1 download is possible though multiple origins. With this
CL, after the first download happens, download from new origins will
require user confirmation to proceed.

With our previous change to store all origin and their corresponding
download status in a map, the TabDownloadState cannot be cleared
unless the map is empty.
If a tab's download count >=1, all download from a non-blocked
origin will require prompt.
User initiated navigation will clear all download status, unless the
origin is blocked in content settings.


BUG=1200874

Change-Id: I6ab4aa77bcfc156fe9f14a341c47c0bc3f6b28e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3161027
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928828}
3 files changed
tree: 4e392498319deb24f119d2c82b546f51f2533804
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.