Google Git
Sign in
chromium / chromium / src / 17617a0cd9b88f98683e2357b75aefe85b209763
commit17617a0cd9b88f98683e2357b75aefe85b209763[log] [tgz]
authorMorten Stenshorne <mstensho@chromium.org>Mon May 12 20:22:27 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 12 20:22:27 2025
treea1f56bc35b4c1c8307c6a1492db374f08385a18c
parentafa6385514d472e56434b58d56e848dd9ab32226 [diff]
Never create flow threads (multicol).

Behind a feature flag / kill switch called FlowThreadLess, which is
enabled for "stable". It depends on the LayoutBoxVisualLocation, because
that is what removed the last real dependency on flow threads.

This disables the legacy classes LayoutFlowThread,
LayoutMultiColumnFlowThread, LayoutMultiColumnSet,
LayoutMultiColumnSpannerPlaceholder, and MultiColumnFragmentainerGroup.

Some changes were required to keep updating the IsInsideMulticol flag
(up until recently known as IsInsideFlowThread). Even more changes were
required to keep column spanners working. The flow thread was
responsible for determining whether a spanner was indeed a valid spanner
or not (and then create a LayoutMultiColumnSpannerPlaceholder object for
it). Now determine this on the fly. We could introduce a bit for it, but
that means more maintenance, and not doing it should be safe and cheap
enough.

Bug: 371802475
Change-Id: Ia712e6b09173d56aa43d8c146707a88a0e46a85b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523802
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1459057}
26 files changed
tree: a1f56bc35b4c1c8307c6a1492db374f08385a18c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.