[context menu] adjust anchor if window is drawn edge-to-edge

AnchoredPopupWindow applies anchorRect assuming origin right below the
window decor.
The input touch point from ContextMenuParams are coordinates relative to
the associated RenderView's origin, i.e. the space not including the
window decor, tabstrip and toolbar. It also provides a vertical offset
of height of tabstrip + toolbar which will be added to the touch point
to compute the anchor rect.

This is correct when edge-to-edge is false, e.g. when window decor is
drawn independently from the tab strip (#tab-strip-layout-optimization
is disabled).
But edge-to-edge is true, i.e. window decor is tabstrip, the offset
will cause the anchor rect to be lower than the true touch point by the
height of tabstrip. See:
Before (flag off): https://screenshot.googleplex.com/8CMJqYcpPpwBdW8
Before (flag on): https://screenshot.googleplex.com/5om8UfsZG4mM3QJ

Therefore, when edge-to-edge is true, subtract from the offset the
height of tabstrip = height of window decor.
After (flag on): https://screenshot.googleplex.com/WCJ2GkgopWu44fQ
After (flag off): https://screenshot.googleplex.com/4WqccMYgnXgZj3Z

Bug: 400499940
Change-Id: Ic3c93901427aee2d246300b9ef76835d05d60a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6629901
Commit-Queue: Grace Cham <hscham@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Auto-Submit: Grace Cham <hscham@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477101}
1 file changed
tree: 5ea77da73edc7802654e023103bcb16c67b213f1
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.