Google Git
Sign in
chromium / chromium / src / 181de6276daa83aa80bc09106f017c5dc20e0e8c
commit181de6276daa83aa80bc09106f017c5dc20e0e8c[log] [tgz]
authorJoey Arhar <jarhar@chromium.org>Wed Sep 28 17:39:48 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 28 17:39:48 2022
treee4530ad25a2753b937f636debb4cd4185009cfd9
parent584badf4a357c706e07fb8cefa55b87a764637b2 [diff]
Update DisplayLock lifecycle registration for top layer

WillStartLifecycleUpdate is only called when the DisplayLockContext is
subscribed to lifecycle updates, and the DisplayLockContext should only
be subscribed to lifecycle updates when NeedsLifecycleNotifications is
true. The DCHECK at the start of WillStartLifecycleUpdate enforces this.

has_pending_top_layer_check_ affects NeedsLifecycleNotifications, which
means that we need to unsubscribe from lifecycle notifications when it
becomes false. This patch adds a line of code to unsubscribe from
notifications when it is set to false.

Running slot-content-visibility-18-crash.html with --iterations=500 was
failing without this patch.

Fixed: 1367977
Change-Id: Ib5aa044d32e87f7dc7f4f8c9ed7cf08e979298ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923916
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1052500}
1 file changed
tree: e4530ad25a2753b937f636debb4cd4185009cfd9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.