| commit | 18400edb9f0d87f64adb0bec1eeb8ef49f88c041 | [log] [tgz] |
|---|---|---|
| author | Arthur Milchior <arthurmilchior@google.com> | Thu Apr 10 15:19:08 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Apr 10 15:19:08 2025 |
| tree | 94032f65494d9fe89bd0a5329a06ed3faef0e23b | |
| parent | 432b3bc6b0d2d7410c61853045c583f6ce182c21 [diff] |
[base]Improve ObjCCast documentation Recently I introduced a bug caused by using `ObjCCast<ClassName<ProtocolName>>`, and checking its return value for `nil`. While this allowed me to discriminate objects of ClassName from object of other classes, I realized that it didn’t properly discriminate for ProtocolName. I hope that making it explicit in the description will ensure less people commit the same error. Admittedly, it’d be even better to ensure that `T` has no protocol specifier. But I’ve no idea how it could be done. Bug: None Change-Id: If33996107172f4549952ed9be9d04aa416a1d17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441133 Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1445313}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.