Google Git
Sign in
chromium / chromium / src / 185bc75e606d4a1d4987019e6d7117b3c1f373da
commit185bc75e606d4a1d4987019e6d7117b3c1f373da[log] [tgz]
authorBruno Braga <brunobraga@google.com>Mon Jul 24 17:06:36 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 24 17:06:36 2023
tree4c6b7a01e2199f3ef71b001466239869834531d2
parentabf649147a73bdca06d44a8f0be86264265d5472 [diff]
[autofill]: Fix autocomplete row accessibility.

The text being announced is incorrect. For some reason there is a mix between the child (button) accessibility name and the content's accessibility name being used in the announcement. After spending some hours I was not able to find out what the root cause is.

Even after building the initial CL where accessiblity was working as expected, tthe error persisted, which makes me think this is related to the OS.

This CL is a temporary fix to the issue so that the feature is not blocked.

before: https://screencast.googleplex.com/cast/NTU3MjI2MzExOTE1OTI5NnwzZmU2NWZjYS0xNw
after: https://screencast.googleplex.com/cast/NjM0MDAzMzAxNjQ5NjEyOHxiNWE3NDQzMC1iYg

Bug: 1417187
Change-Id: I81e5892dcfdc6066424799b44ad3277f15a86362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4710451
Reviewed-by: Jan Keitel <jkeitel@google.com>
Commit-Queue: Bruno Braga <brunobraga@google.com>
Cr-Commit-Position: refs/heads/main@{#1174265}
2 files changed
tree: 4c6b7a01e2199f3ef71b001466239869834531d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.