commit | 185e0147ea29497f2022eb4834e62fe8d105d33f | [log] [tgz] |
---|---|---|
author | James Cook <jamescook@chromium.org> | Mon Jan 08 20:36:13 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 08 20:36:13 2024 |
tree | 00d6b87e4facf76040597ab99f7d258f7b7f9f4b | |
parent | d6a1ebbeb21f52ce6c4f9c7b1ae6770248951e65 [diff] |
ui: Promote DCHECK to CHECK in ContentSettingMediaStreamBubbleModel There are some crashes in UI string lookup that appear to be caused by bad assumptions about invariants for camera and microphone access. Promote the existing DCHECKs to CHECKs so we can see what's actually happening in the field. Bug: 1516745 Change-Id: Ie49fda68935ecf1b76b42cf38253402a285b6040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5174593 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#1244239}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.