[iOS] Crash bug fix for WebStateImpl being null during download process

This is a merge to M103. 

There's currently a bug where a user crashes during the download
process due to WebState being null. Reproducing the crash through a
unit/eg test is currently difficult since the cause of the crash seems
to be time dependent hence why there isn't a unit test accompanied with
the fix to test if it works. Existing unit tests have also been
updated to pass the tests since we can't replicate a delegate call since
the delegate is set to nil. This way, unit tests can still pass as if
the delegate existed and wasn't prematurely cancelled.

(cherry picked from commit 13df7d189b853bb670f87420e29418f2b55856d1)

Fixed: 1325108
Change-Id: I72a54fcddde20d95061642539c3553b0e3c219ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648169
Commit-Queue: Joemer Ramos <joemerramos@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1004248}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661421
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Joemer Ramos <joemerramos@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#217}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
4 files changed
tree: 73cf1bd3ab42bf4d3ce4c2e831b879376d58ee2d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.