commit | 1865175f3ec25bff7b472981f5743ed6c3318ad1 | [log] [tgz] |
---|---|---|
author | Joemer Ramos <joemerramos@chromium.org> | Tue May 24 12:31:31 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 24 12:31:31 2022 |
tree | 73cf1bd3ab42bf4d3ce4c2e831b879376d58ee2d | |
parent | 7b0821ee7aebb54ce335617b6a5478810607e28c [diff] |
[iOS] Crash bug fix for WebStateImpl being null during download process This is a merge to M103. There's currently a bug where a user crashes during the download process due to WebState being null. Reproducing the crash through a unit/eg test is currently difficult since the cause of the crash seems to be time dependent hence why there isn't a unit test accompanied with the fix to test if it works. Existing unit tests have also been updated to pass the tests since we can't replicate a delegate call since the delegate is set to nil. This way, unit tests can still pass as if the delegate existed and wasn't prematurely cancelled. (cherry picked from commit 13df7d189b853bb670f87420e29418f2b55856d1) Fixed: 1325108 Change-Id: I72a54fcddde20d95061642539c3553b0e3c219ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648169 Commit-Queue: Joemer Ramos <joemerramos@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1004248} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3661421 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Joemer Ramos <joemerramos@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#217} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.