Google Git
Sign in
chromium / chromium / src / 18658d2470f29ffb4cd4f7e52a4744713b4f7d6b
commit18658d2470f29ffb4cd4f7e52a4744713b4f7d6b[log] [tgz]
authorColin Blundell <blundell@chromium.org>Thu Dec 05 09:08:48 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Dec 05 09:08:48 2024
tree1e70c4a0fa63882329f68af5a1f968d1cab9b686
parentfad6588c844e8fe93b592957f0230e06cbb386f0 [diff]
[Blink] Eliminate check on canvas_2d_bridge_ from DisableAcceleration()

This method is Canvas2D-specific and by design is called in production
only from CanvasRenderingContext2D [1].
ReplaceExisting2DLayerBridge() short-circuits out if there is no
ResourceProvider [2]. If there *is* a ResourceProvider
`canvas_2d_bridge_` is guaranteed to also be non-null (as outlined in
the CL description in [3]), making the check at the callsite
unnecessary.

Note: This is analogous to RecreateCanvasInGpuRasterMode() [4].

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=1099;drc=5108636c70c0b08fdbeb57de2640a22e138f6685
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=1880-1883;drc=5108636c70c0b08fdbeb57de2640a22e138f6685;bpv=1;bpt=1
[3] https://chromium-review.googlesource.com/c/chromium/src/+/6038064
[4] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=1645?q=RecreateCanvasIn&sq=&ss=chromium

Change-Id: I45aea81aec0f57ef61060e93de0d814822e3e5b2
Bug: 40280152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6068774
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1392127}
1 file changed
tree: 1e70c4a0fa63882329f68af5a1f968d1cab9b686
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.