Fix potential UaF in ConversionStorage

Currently, ConversionStorageSql is instantiated and owned by a
ConversionManager instance. ConversionStorageSql is solely accessed
through a SequencedTaskRunner, and is deleted on the same sequence that
it is accessed. ConversionStorageSql also holds a pointer to the manager
which implements the ConversionStorage::Delegate.

Because of this setup, it is possible for the ConversionManager to be
destroyed when there are still storage tasks in the queue that require
a StorageDelegate. Because the storage instance is deleted on the
sequence, the pointer to the ConversionManager is no longer valid and it
will still be accessed.

This change fixes this potential behavior by moving the Delegate
implementation off ConversionManager, and into a separate class that is
only accessed on the storage sequence and owned by ConversionStorageSql.
Because ConversionPolicy cannot be shared, storage related methods are
pulled onto the DelegateImpl.

Bug: 1059840
Change-Id: Ie0fdf7a07d3dbe75359bb29b0dfea8a973ca3db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095435
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756454}
14 files changed
tree: 5ccd3a006d9f443ab02b105cf75688a6d84463f4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.