Fix potential UaF in ConversionStorage Currently, ConversionStorageSql is instantiated and owned by a ConversionManager instance. ConversionStorageSql is solely accessed through a SequencedTaskRunner, and is deleted on the same sequence that it is accessed. ConversionStorageSql also holds a pointer to the manager which implements the ConversionStorage::Delegate. Because of this setup, it is possible for the ConversionManager to be destroyed when there are still storage tasks in the queue that require a StorageDelegate. Because the storage instance is deleted on the sequence, the pointer to the ConversionManager is no longer valid and it will still be accessed. This change fixes this potential behavior by moving the Delegate implementation off ConversionManager, and into a separate class that is only accessed on the storage sequence and owned by ConversionStorageSql. Because ConversionPolicy cannot be shared, storage related methods are pulled onto the DelegateImpl. Bug: 1059840 Change-Id: Ie0fdf7a07d3dbe75359bb29b0dfea8a973ca3db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095435 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#756454}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.