Google Git
Sign in
chromium / chromium / src / 18966bc75cf721c39fd304fdceff1e40b80c6893
commit18966bc75cf721c39fd304fdceff1e40b80c6893[log] [tgz]
authorWenyu Fu <wenyufu@chromium.org>Thu Nov 14 03:37:15 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 14 03:37:15 2024
tree486a1db6d997405a8a97a5d68f5d5a4ea8afcb86
parent821b5fda458f4dc3058bcc64145bffeb43ae70cc [diff]
[E2E] Read system bar insets for edge to edge

Before this CL, EdgeToEdgeControllerImpl observe insets changes for
navigation bar and status bar. On some OEM (e.g. Redmi), their split
screen window has a captionBar insets which is not handled in edge to
edge, and part of the Chrome UI will draw under those insets, make
Chrome broken.

This CL makes EdgeToEdgeController reads all systemBar insets
(captionBar + statusBar + navigationBar) to fix the issue. Verified on
device that doesn't use captionBars, there's no impact observed.

--

Risks: this new logic might be broken if we have captionBar insets coming from the bottom. TBD if any OEM has this behavior.

--

Demo:

Redmi:
https://screencast.googleplex.com/cast/NTE2MzgyMDY4NjI0NTg4OHxiMjIyNzAwOC1mYw
Pixel 5a:
https://screencast.googleplex.com/cast/NTU2ODI0MTMzMzE3NDI3MnxjZmNiOGM4My01OQ

Bug: 377620837
Change-Id: Ib6c0bf1bd86d4c41e1c6db0d84fa44e0d7d66ce8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6020232
Reviewed-by: Charles Hager <clhager@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382786}
1 file changed
tree: 486a1db6d997405a8a97a5d68f5d5a4ea8afcb86
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.