commit | 18b3188a138b576dd960d78f0c0cce79bafbf37d | [log] [tgz] |
---|---|---|
author | Jared Saul <jsaul@google.com> | Tue Apr 23 21:48:00 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Apr 23 21:48:00 2019 |
tree | f144e1ed33a88f15c33221fcc6bd7ebdad9325b8 | |
parent | 1ad7b466dba8a6b8bd5d295dda25866702d7d7aa [diff] |
[Autofill] Action base::Optional suggestions from seblalancette@ I opted to use ".has_value() &&" instead of ".value_or(~)" in some places for generally readability reasons. We don't want to log certain metrics or strikes if the value was missing (which SHOULD almost never happen, but rare race conditions are possible) and I don't want to switch between _or(true) and _or(false) as necessary in those situations. Change-Id: Ieec56f5cdf9cae8855b17d49ed78a9850a2a8c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576107 Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653381}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .