Google Git
Sign in
chromium / chromium / src / 67f0872c613adb937b9dd6cc358808fd04009c14
commit67f0872c613adb937b9dd6cc358808fd04009c14[log] [tgz]
authorJoanmarie Diggs <jdiggs@igalia.com>Wed Jun 22 20:54:55 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 22 20:54:55 2022
tree4275794490a33f212e6144b9ab49e49a4b1e25b7
parentda2ec58f64a4986e99d1799b711dade577a2a5f0 [diff]
Don't fire load-complete AX notification on macOS for unfocused windows

If VoiceOver is launched when Chrome is the active application, we
fire a load-complete notification. In response, VoiceOver may update
update focus and start reading the contents of windows which are not
active (e.g. another Chrome window is active, or this is the only
Chrome window, but it is minimized). This behavior can be unexpected
and confusing.

In order to prevent this from occurring, check that the current window
is the focused window according to the app prior to firing an
NSAccessibilityLoadCompleteNotification. This should hopefully also
prevent subsequent page loads from a non-focused Chrome window from
causing unexpected presentation by VoiceOver.

AX-Relnotes: VoiceOver should no longer present content from non-focused
Chrome windows upon launch.

Bug: 1078482
Change-Id: If38f56d1b5464f08f27a25585d2f6c4de88b87dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3695403
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016863}
2 files changed
tree: 4275794490a33f212e6144b9ab49e49a4b1e25b7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.