Google Git
Sign in
chromium / chromium / src / 18e85001a6fd00f8600f77a905ea5e135018e3f1
commit18e85001a6fd00f8600f77a905ea5e135018e3f1[log] [tgz]
authorGreg Thompson <grt@chromium.org>Wed Sep 08 20:52:28 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 08 20:52:28 2021
tree162452e8cbd560a6e2719244bf74eaadbaafb9d4
parent64a82a909590937e271dae9aeaf39e7c9c04fdf2 [diff]
[Windows] Handle some more error codes in File::OSErrorToFileError.

- Map the bespoke ReplaceFile errors to FILE_ERROR_IN_USE, since they
  generally mean that some other entity is preventing operations on one
  or both of the files in play.
- Map LOCK_VIOLATION to FILE_ERROR_ACCESS_DENIED, since that's kinda
  what it means (the holder of the lock is denying you access, right?).
- Map GEN_FAILURE and DISK_OPERATION_FAILED to FILE_ERROR_IO, since they
  mean that something bad happened while talking to the device.

Also, add a few popular values to the WinGetLastError histogram enum.

Bug: 1175817
Change-Id: Ie7df2c3ee4cdbbbc6e013fec6a4081cfdc41b32e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3147390
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919435}
2 files changed
tree: 162452e8cbd560a6e2719244bf74eaadbaafb9d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.