[shared storage] Bugfix: Check the permissions policy against the script origin

When creating or using a cross-origin worklet, the code is doing the
wrong checks via IsFeatureEnabled(...) (for all "shared-storage",
"shared-storage-select-url", and "private-aggregation"). It should
instead be policy->IsFeatureEnabledForOrigin(...) which checks against
the script origin (i.e. the worklet/data/security origin), as
specified in the spec.

We move the permissions check to after the "was addModule invoked"
check. This way, we can use a single `worklet_host_` state to
track both "addModule invoked" status and "shared_storage_origin_" eligibility, reducing state management overhead. As a result:
- This also eliminates redundant checks for the
  "shared-storage" permissions policy during selectURL() & run().
- We'd have to relax some assertions in WPT by not asserting the
  exact error messages. This is nevertheless the desired pattern,
  as the error messages are not part of the spec.

Bug: 347047842
Change-Id: I9e14810e803af20fb0b5cc7837c6b434f887ab9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5630917
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1315333}
21 files changed
tree: 307689721b0fd9e20c06db4c834b88b012d6ae80
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.