Google Git
Sign in
chromium / chromium / src / 1942bde3a3216402d9f44a8cdc3990f634f95ee0
commit1942bde3a3216402d9f44a8cdc3990f634f95ee0[log] [tgz]
authorColin Blundell <blundell@chromium.org>Thu Nov 25 16:16:08 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 25 16:16:08 2021
treee32b0a72435f5cb6b6da33065062f5ca6448cbeb
parent0f22a2dcb3aa9809211e193f4094803f2251f8e4 [diff]
[StartupTabPreloader] Record metrics only when tracking startup metrics

Certain recently-added StartupTabPreloader startup latency metrics are
not inherently gated on ActivityTabStartupMetricsTracker recording its
startup metrics. Examination of the recently-added metrics on canary
shows that this makes them unable to be used for comparison with the
more general startup metrics (e.g., 99% latency of > 3 minutes rather
than the expected < 15 seconds).

This CL gates recording of those metrics by
ActivityTabStartupMetricsTracker tracking its own startup metrics.

Bug: 1258621
Change-Id: I669c00e6d3a665f114d6209575026f641dca5e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3301044
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945408}
2 files changed
tree: e32b0a72435f5cb6b6da33065062f5ca6448cbeb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.