Google Git
Sign in
chromium / chromium / src / 19578e9da2337ae3fa0950b35c379ad2699d62ed
commit19578e9da2337ae3fa0950b35c379ad2699d62ed[log] [tgz]
authorDave Tapuska <dtapuska@chromium.org>Mon Aug 09 17:14:02 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 09 17:14:02 2021
treefd6b94af1907ba07c81b5b0706137dc1ec38d199
parent9b25a6f9e235fd02ff8b0b8f8a830a3ae8f4bfc6 [diff]
Make sure RunBeforeUnloadConfirm is a no-op for non-active pages.

We should never receive a request to confirm a before unload handler
for a prerender because that is gated on having sticky User Activation.
It is possible to receive it in other scenarios so we respond false if
we receive it. This code use to exist in WebContentsImpl but this makes
it consistent with the other JavaScriptDialog method which checks
IsActive inside RFHI.

Remove unused WillRunBeforeUnloadConfirm callback. Add a test as well.

BUG=1237034

Change-Id: I34ea029b79252016f051016d68682dd16c304cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075200
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#909842}
5 files changed
tree: fd6b94af1907ba07c81b5b0706137dc1ec38d199
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.