Google Git
Sign in
chromium / chromium / src / 19f0a84e97e68667156ecd1e478f5c5f25a2c4d1
commit19f0a84e97e68667156ecd1e478f5c5f25a2c4d1[log] [tgz]
authorRupert Wiser <bewise@chromium.org>Fri Dec 08 18:03:22 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 08 18:03:22 2023
treea3950c5a2f942dcf597046c9be592c0890e8b973
parent95d29836162c021d4d024bf3f2999a3c1fe77033 [diff]
Revert "[A11y] Add CHECK and DUMP for IsIgnored() crash"

This reverts commit 370671dbd74b37cded2066105baec48c93ce82f4.

Reason for revert: The check added in this change will cause Android data lists to crash - confirmed in WebView. Android [explicitly adds a nullptr as a tree](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/accessibility/web_contents_accessibility_android.cc;l=1325;drc=8e78783dc1f7007bad46d657c9f332614e240fd8).

Original change's description:
> [A11y] Add CHECK and DUMP for IsIgnored() crash
>
> Fixed: 1500432
> Change-Id: I38270ec76f79406790207ab90fdea362873f4f7c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5049671
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1229617}

Change-Id: I802cd5c6ac8798e5109d28c9017c4b67a7db61dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100268
Auto-Submit: Rupert Wiser <bewise@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1235099}
2 files changed
tree: a3950c5a2f942dcf597046c9be592c0890e8b973
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.