Google Git
Sign in
chromium / chromium / src / 19ff7f8c03662427df79327554eb542b09d0b7d8
commit19ff7f8c03662427df79327554eb542b09d0b7d8[log] [tgz]
authorAlan Ding <alanding@google.com>Tue Aug 31 04:33:53 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 31 04:33:53 2021
treeb42f8472adbd5eaf2b7e086190552d87f78bc369
parent610c4e099069e96b73c8b8ecc3c1b1e9dcf060f9 [diff]
arc: Simplify session cleanup after NearbyShare close reason fix

With the fix in https://crrev.com/c/3120239, we will route the
appropriate close reason for the Nearby Share bubble as either
success or cancel. Since we were only calling OnNearbyShareClosed()
previously with kCancel reason, OnCleanupSession() was not being called
in certain scenarios and we needed an extra session_finished_callback_
as WA in OnNearbyShareClosed(). Now this is not needed and we also want
to avoid calling the callback twice in OnNearbyShareClosed().

BUG=1243173, b:184720732
TEST=Verify sharing from Photos with https://crrev.com/c/312023 locally
including "Accept" and "Cancel" cases.

Change-Id: I5e7713b08437f4a996cd14575569f7c021b7337d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3125586
Commit-Queue: Alan Ding <alanding@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#916686}
1 file changed
tree: b42f8472adbd5eaf2b7e086190552d87f78bc369
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.