commit 1a47bc4c4945862b6f2955e3e8b248460e250763
author Eva Herencsarova <evih@google.com> Wed Aug 10 11:24:11 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 10 11:24:11 2022
tree ca8a5d537cbbe05dd81513b346866061b8ed5456
parent 3ff242e404893b39a5b22beba9a95d49fe6dd501

[Autofill] Fix incorrect assignment in IdentifySectionsWithNewMethod()

Before the autocomplete_section_attribute_present boolean in IdentifySectionsWithNewMethod() was incorrectly set iff the field's section was not the default value. However, the field's section might no longer be the default value when the section prefix_ is set to credit card value in IdentifySectionsWithNewMethod().
Furthermore, IdentifySectionsWithNewMethod() changes the section (i.e. the section is no longer default), and is called once again when the server predictions arrive. Therefore, in this case the autocomplete_section_attribute_present is always true, which should not be the desired behavior.

This change sets autocomplete_section_attribute_present iff the section's prefix was derived from the autocomplete attribute, as its name suggests.

Change-Id: Ia185ac3eff2652ed14591110778358c9248e27c1
Bug: 1076175, 1153539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3810630
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Eva Herencsarova <evih@google.com>
Cr-Commit-Position: refs/heads/main@{#1033455}