Google Git
Sign in
chromium / chromium / src / 1a66612dbfcf0513ccd77e81a91fef46bd0eead5
commit1a66612dbfcf0513ccd77e81a91fef46bd0eead5[log] [tgz]
authorGavin Williams <gavinwill@chromium.org>Fri Sep 25 21:52:49 2020
committerCommit Bot <commit-bot@chromium.org>Fri Sep 25 21:52:49 2020
tree8328cc6d5d8c730d2b91c92aef324983afc0478a
parentccedfa2ad315f49d5cdd57482e7f6b2c470a3532 [diff]
Add GetBrowserContextToUse override to PrintManagementFactory

In guest mode print jobs did not appear in print management app. This
prevented users being able to cancel in-progress jobs.

Overriding GetBrowserContextToUse allows using an OTR profile so that
jobs appear in the app.

Added function BuildInstanceFor for creating PrintManagement service in
tests.

Bug: 1128690
Change-Id: I837afd57711505e7bf8ab93f9aa38ed16dc5d3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412222
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810812}
4 files changed
tree: 8328cc6d5d8c730d2b91c92aef324983afc0478a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.