commit 1b0a12df35ed2641396754b62bb1a7aa31e48095
author Justin Huang <justinhuang@google.com> Wed Sep 07 08:47:55 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 07 08:47:55 2022
tree 251f352b169faaab385f831f328aa25302a40467
parent 45e266f4b1b06ed7adeb27ec4f21fb1353139922

Fixes CrostiniInstaller's interaction with AnsibleManagementService

CrostiniInstaller had a race with CrostiniManager where
AnsibleManagementService would send a failure signal via observer to
CrostiniInstaller and a failure to CrostiniManager via a callback. This
would cause both to fail out and send failure signals to each other -
this "worked" before because CrostiniInstaller had a specific clause to
ignore things that had already failed (if state_ != State::ERROR <etc>).
This CL removes CrostiniInstaller's dependency on
AnsibleManagementService since it doesn't actually need to care about
this and instead just relies on the fact that CrostiniManager tells
CrostiniInstaller about the failures of AnsibleManagementService.

This CL also removes the constant need to reconfigure on every restart of the default penguin container if enterprise has specified a playbook since this repeated run of the playbook is quite pointless and would create slowness for no reason.

NOTE: The test change in crostini_manager_unittest will be overwritten
by a future CL anyway.

LOW_COVERAGE_REASON=Unrelated to this CL

Bug: b:227085253
Test: Unittests/Browsertests run
Change-Id: Icb4400b445e3d2233fb51e3b10eaa1bcef77c071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3874636
Commit-Queue: Justin Huang <justinhuang@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1043875}